Re: [PATCH v3 2/5] pretty: make %H/%h/etc respect --abbrev[-commit]

From: Jonathan Nieder <jrnieder@gmail.com>
Date: May 2, 2010, 09:17 UTC
Message-ID: <20100502091720.GB1854@progeny.tock>
In-Reply-To: <7vaasiwtvt.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:

> Will Palmer <wmpalmer@gmail.com> writes:

Show 8 quoted lines

>> If the current behaviour is actually intentional, we should at least
>> update the documentation to say that %H is the "full commit hash",
>> rather than just the "commit hash".
>
> I think it was obvious from the context that lists %H and %h next to each
> other, with description without "abbreviated" and with "abbreviated" to
> them.  The description for %H should be rewritten as "commit object name"
> and %h "abbreviated commit object name".

FWIW, this is why I suggested updating the documentation. I think the “%H becomes %h in the presence of --abbrev-commit” behavior would be more useful in practice.

But I am not fanatical about it. Maybe this functionality should get some other letter and I would just not use %H.

Jonathan