git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: kernel.org now has gitweb installed

From
Junio C Hamano <junkio@cox.net>
Date
Apr 28, 2005, 21:21 UTC
Message-ID
<7v1x8u7g26.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<Pine.LNX.4.58.0504281149330.18901@ppc970.osdl.org>
>>>>> "LT" == Linus Torvalds <torvalds@osdl.org> writes:

LT> So what you can do is: LT> - if there is one parent, just always walk straight down LT> - if it's a merge, add the parents _in_date_order_ to the list of things LT> to do, and then pop the most recent one. LT> Really. You say that dates don't matter, but they _do_ actually matter a LT> lot more than "remote/local" does. At least they have meaning.

On a related topic, I have two questions on commit objects.
1. Currently, commit-tree does not seem to verify that all its
   parent SHA1's actually name valid commit objects.  Is this
   intentional?

I cannot see a good practical reason to commit a new version that claim to be descendant of some SHA1 you know exists in somebody else's tree, without actually having that object also in your SHA1_FILE_DIRECTORY. Otherwise how did you merge with it in the first place? For that reason, I expect the answer to this question to be "no it was just being lazy. Go ahead if you really care."

2. Assuming that we do want to enforce that parent fields of a
   commit object name valid commit objects, is it OK to also
   require that the commit timestamp of a child object is not in
   the future relative to any and all of its parent commit
   objects (I'm talking about the timestamp of committer field
   not author field, although your e-mail patch acceptance
   procedure seems to be giving it the same timestamp right
   now)?

I have been wondering if imposing these two requirement has some negative effects, but I do not offhand see any. And these requirements may make implementation of git log viewer simpler when the user specifies "I want to view commit between these ones---give me a linearlized list of commits." When following the ancestor chain from the current top, we can immediately stop upon seeing a commit made before the timestamp of the named bottom one.

Previous: Jan HarkesNext: David Woodhouse
Message 16 of 23 in “kernel.org now has gitweb installed”
  1. H. Peter AnvinApr 28, 2005
  2. Daniel JacobowitzApr 28, 2005
  3. David WoodhouseApr 28, 2005
  4. Petr BaudisApr 28, 2005
  5. David WoodhouseApr 28, 2005
  6. David WoodhouseApr 28, 2005
  7. Linus TorvaldsApr 28, 2005
  8. David WoodhouseApr 28, 2005
  9. Linus TorvaldsApr 28, 2005
  10. David WoodhouseApr 28, 2005
  11. H. Peter AnvinApr 28, 2005
  12. H. Peter AnvinApr 28, 2005
  13. Linus TorvaldsApr 28, 2005
  14. David WoodhouseApr 28, 2005
  15. Jan HarkesApr 29, 2005
  16. Junio C HamanoApr 28, 2005
  17. David WoodhouseApr 28, 2005
  18. Junio C HamanoApr 28, 2005
  19. Linus TorvaldsApr 28, 2005
  20. Gerhard SchrenkApr 28, 2005
  21. David WoodhouseApr 28, 2005
  22. Junio C HamanoApr 28, 2005
  23. Linus TorvaldsApr 28, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.