Re: [PATCH][RFC] Add git-archive-tree
- From
Junio C Hamano <junkio@cox.net>
- Date
- Sep 2, 2006, 21:19 UTC
- Message-ID
- <7v1wquynj5.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <44F982BD.1050509@lsrfire.ath.cx>
Rene Scharfe <rene.scharfe@lsrfire.ath.cx> writes:
> Does it make sense to change the wire protocol to simply send the > command line options one by one?
Which wire protocol are you talking about? The one between upload-tar and local "tar-tree --remote"? I think that one was a tar-tree specific hack and we do not want to mimic it.
Your idea of making archiver neutral upload/download pair makes sense. The daemon can invoke upload-archive with a single parameter (the repository, "."), just like upload_tar() in "pu:daemon.c" does [*1*], and upload-archive talks with the other end to know which archiver to run with what paramter. We would probably want to use some sort of side-band mechanism so that we can do progress-bar as well.
*1* Unrelated side note. I find myself typing "git less" quite
often ;-)git less pu:daemon.c
and get "no such command, dummy" response.
Yes, I know I could alias it to "-p cat-file -p". I am just
too lazy to do so.-- VGER BF report: U 0.709954