Re: [PATCH][RFC] Add git-archive-tree

From: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
Date: Sep 17, 2006, 11:54 UTC
Message-ID: <450D3765.9090303@lsrfire.ath.cx>
In-Reply-To: <7v4pvk7jmn.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano schrieb:

Show 11 quoted lines

> Rene Scharfe <rene.scharfe@lsrfire.ath.cx> writes:
> 
>> I then let the two chew away on the kernel repository.  And as 
>> kcachegrind impressively shows, all we do with our trees and 
>> objects is dwarfed by inflate().
> 
> The diff output codepath has a logic that says "if the blob we are 
> dealing with has the same object name as the corresponding blob in 
> the index, and if the index entry is clean (i.e. it is known that the
>  file sitting in the working tree matches the blob), then do not 
> inflate() but use data from that file instead".

Nice idea. The tree traverser would need to provide the filenames relative to the current working directory in addition to the filenames as they are written to the archive. I guess your para-walk tree walker could be useful here. I sadly haven't found the time to look at it, yet, and now it even vanished from the pu branch.

A read is an order of magnitude faster than a deflate of the same data, at least that's what I guess from comparing the runtimes of git-tar-tree and tar. _However_, this doesn't account for I/O costs (in my tests the repo and all checked-out files were cache hot) and for any compression that would certainly be applied to the resulting archive. So the full runtime of archive creation wouldn't be that much shorter.

René