Re: [PATCH][RFC] Add git-archive-tree

From: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
Date: Sep 2, 2006, 16:08 UTC
Message-ID: <44F9AC75.3020302@lsrfire.ath.cx>
In-Reply-To: <cda58cb80609020824ja524444uc9fe65ea2e4febba@mail.gmail.com>

Franck Bui-Huu schrieb:

Show 11 quoted lines

> Hi,
> 
> 2006/9/2, Rene Scharfe <rene.scharfe@lsrfire.ath.cx>:
>> git-archive-tree is a command to make tar and ZIP archives of a git tree.
>> It helps prevent a proliferation of git-{format}-tree commands.  This is
>> useful e.g. for remote archive fetching because we only need to write a
>> single upload and a single download program that simply pass on the
>> format option to git-archive-tree.
> 
> OK, Rene you beat me. I started to cook up something this morning but
> had no time to go further.

I am sorry. My excuse is I was so angry the other night (for unrelated reasons) that I started coding and I didn't stop until git-archive-tree was working at three in the morning.

Show 5 quoted lines

> I sent a starting implementation just because it seems complementary
> to the one you sent a couple hours ago: it supports '--remote' option.
> But it does _not_ have path spec support you introduced. I think it's
> cool feature but I would have to dig into git's internal to implement
> it, which would have taken me a while.

I cheated by using the already existing function read_tree_recursive().

> From now, do you think we should import my work into your version or
> 'vice verca' ?

Of course I like mine better. :-) But first we need to agree on a direction. I think it makes sense to keep the network stuff out of the archiver, and to keep the downloader as simple ("dumb") as possible: it should pass on any options unaltered, including the format option.

That means the wire format changes completely, but since this feature hasn't been officially released, yet, this shouldn't be a problem, right?

So, I propose to not add anything (except new formats) to git-archive-tree and to add a separate downloader and uploader (maybe combined in one program) instead. That way the remote archive operations are format agnostic. OK, almost, because the uploader needs to determine the format and compression level in order to allow or disallow uploads based on that.

What do you think?

Thanks, René

-- 
VGER BF report: U 0.539485