Re: git and time

From: Junio C Hamano <junkio@cox.net>
Date: Sep 27, 2006, 20:46 UTC
Message-ID: <7v1wpx9gwk.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20060927151102.GC20705@spearce.org>

Shawn Pearce <spearce@spearce.org> writes:

Show 6 quoted lines

> You are missing:
> +	setup_ident();
>
> Without that reflog can't get the proper committer data from the
> host's gecos information.  This is probably what is desired for
> most pushes over SSH.

What's even more interesting is when there is .git/config file and you do not override it with environment variables; the log entry will be made under the name of the repository user.name in such a case.

>> +	git_config(git_default_config);
>> +
>>  	write_head_info();

Often setup_ident() needs to go together with git_config(), and you need to remember that setup must come before config. These rules are a bit cumbersome to follow and I often forget.

I wonder if we can have a simpler start-up sequence perhaps to avoid future mistakes like this?