Re: [PATCH] fetch: don't output non-errors on stderr

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 25, 2010, 21:43 UTC
Message-ID: <7v1vbukcu8.fsf@alter.siamese.dyndns.org>
In-Reply-To: <AANLkTilToJ2ekKVgIeka5qx9_lasw6DKSy8bOhTrP4dC@mail.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

Show 11 quoted lines

> On Fri, Jun 25, 2010 at 17:25, Junio C Hamano <gitster@pobox.com> wrote:
>> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>>
>>> Before the change error messages were drowned out by git-fetch's
>>> non-error update notices, which didn't need my attention.
>>
>> I don't understand this part; care to elaborate?
>
> I have a cron job (github-backup) that calls git fetch. Without this
> patch I have to run it as '> /dev/null 2>&1' and just rely on the exit
> code,

Signaling failure with exit code is _the_ standard practice, no?

Some people seem to think unclean standard error means some error (most notably tcl ;-), but I think they are mistaken.

Not that I care too much about this issue, though. I might end up queuing it, but we need to think about things like advice messages and such (e.g. 011fe98 (git-push: fix an advice message so it goes to stderr, 2010-02-26)).