From: Junio C Hamano Date: Fri, 25 Jun 2010 21:43:27 GMT Subject: Re: [PATCH] fetch: don't output non-errors on stderr Message-ID: <7v1vbukcu8.fsf@alter.siamese.dyndns.org> In-Reply-To: Ævar Arnfjörð Bjarmason writes: > On Fri, Jun 25, 2010 at 17:25, Junio C Hamano wrote: >> Ævar Arnfjörð Bjarmason writes: >> >>> Before the change error messages were drowned out by git-fetch's >>> non-error update notices, which didn't need my attention. >> >> I don't understand this part; care to elaborate? > > I have a cron job (github-backup) that calls git fetch. Without this > patch I have to run it as '> /dev/null 2>&1' and just rely on the exit > code, Signaling failure with exit code is _the_ standard practice, no? Some people seem to think unclean standard error means some error (most notably tcl ;-), but I think they are mistaken. Not that I care too much about this issue, though. I might end up queuing it, but we need to think about things like advice messages and such (e.g. 011fe98 (git-push: fix an advice message so it goes to stderr, 2010-02-26)).