Re: [PATCH] fetch: don't output non-errors on stderr

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Jun 25, 2010, 21:28 UTC
Message-ID: <AANLkTilToJ2ekKVgIeka5qx9_lasw6DKSy8bOhTrP4dC@mail.gmail.com>
In-Reply-To: <7v1vbvkorf.fsf@alter.siamese.dyndns.org>

On Fri, Jun 25, 2010 at 17:25, Junio C Hamano <gitster@pobox.com> wrote:

Show 6 quoted lines

> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>
>> Before the change error messages were drowned out by git-fetch's
>> non-error update notices, which didn't need my attention.
>
> I don't understand this part; care to elaborate?

I have a cron job (github-backup) that calls git fetch. Without this patch I have to run it as '> /dev/null 2>&1' and just rely on the exit code, with it I can just do '> /dev/null' and not ignore stderr, because non-error output isn't being sent there anymore.

In short, the current git-fetch breaks the conventional *nix assumption that stderr only contains errors. With this patch errors go to stderr and normal output to stdout.