Re: [PATCH] fetch: don't output non-errors on stderr

From: Jeff King <peff@peff.net>
Date: Jun 26, 2010, 16:46 UTC
Message-ID: <20100626164618.GA18517@coredump.intra.peff.net>
In-Reply-To: <AANLkTik6jbcOtyXJ5JJav1xnLEO6RSmYTHpsX6yYaB5_@mail.gmail.com>

On Sat, Jun 26, 2010 at 12:14:59PM +0000, Ævar Arnfjörð Bjarmason wrote:

Show 12 quoted lines

> On Sat, Jun 26, 2010 at 06:13, Jeff King <peff@peff.net> wrote:
> 
> > Or even easier: is there a reason that "git fetch -q" would not do what
> > you (Ævar) want?
> 
> That'd reduce the verbosity level, which'd skip some messages that I
> might want. E.g.:
> 
> 		if (verbosity >= 0) {
> 			fprintf(stderr, " x %-*s %-*s -> %s\n",
> 				TRANSPORT_SUMMARY_WIDTH, "[deleted]",
> 				REFCOL_WIDTH, "(none)", prettify_refname(ref->name));

Wait, what? Isn't that line also part of the same human-readable status table? What makes the status of a pruned ref any different than the status of an updated ref? I don't see how that is an error message, but the other lines are not.

-Peff