git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 16/48] i18n: git-pull eval_gettext + warning message

From
Junio C Hamano <gitster@pobox.com>
Date
May 8, 2011, 20:19 UTC
Message-ID
<7v1v09rlmt.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20110508165254.GA20654@pcpool00.mathematik.uni-freiburg.de>

"Bernhard R. Link" <brl+ccmadness@pcpool00.mathematik.uni-freiburg.de> writes:

Show 8 quoted lines
>> +	echo >&2 "$(eval_gettext "Warning: fetch updated the current branch head.
>> +Warning: fast-forwarding your working tree from
>> +Warning: commit \$orig_head.")"
>
> echo "$(...)"
>
> sounds quite wasteful and harder to read than necessary.
> The same also happens in later patches.

A very good point. Just letting eval_gettext write out to >&2 should be both sufficient and inifinitely more readable.

Previous: Bernhard R. LinkNext: Ævar Arnfjörð Bjarmason
Message 19 of 59 in “i18n: Add shell script translations (depends on infrastructure)”
  1. 00/48 i18n: Add shell script translations (depends on infrastructure)Ævar Arnfjörð Bjarmason, May 8, 2011
  2. 01/48 i18n: git-am add git-sh-i18nÆvar Arnfjörð Bjarmason, May 8, 2011
  3. 02/48 i18n: git-am one-line gettext $msg; echoÆvar Arnfjörð Bjarmason, May 8, 2011
  4. 03/48 i18n: git-am multi-line getttext $msg; echoÆvar Arnfjörð Bjarmason, May 8, 2011
  5. 04/48 i18n: git-am eval_gettext messagesÆvar Arnfjörð Bjarmason, May 8, 2011
  6. 05/48 i18n: git-am echo + gettext messageÆvar Arnfjörð Bjarmason, May 8, 2011
  7. 06/48 i18n: git-am die messagesÆvar Arnfjörð Bjarmason, May 8, 2011
  8. 07/48 i18n: git-am cannot_fallback messagesÆvar Arnfjörð Bjarmason, May 8, 2011
  9. 08/48 i18n: git-am clean_abort messagesÆvar Arnfjörð Bjarmason, May 8, 2011
  10. 09/48 i18n: git-am "Apply?" messageÆvar Arnfjörð Bjarmason, May 8, 2011
  11. 10/48 i18n: git-am "Falling back" say messageÆvar Arnfjörð Bjarmason, May 8, 2011
  12. 11/48 i18n: git-am core say messagesÆvar Arnfjörð Bjarmason, May 8, 2011
  13. 12/48 i18n: git-am printf(1) message to eval_gettextÆvar Arnfjörð Bjarmason, May 8, 2011
  14. 13/48 i18n: git-pull add git-sh-i18nÆvar Arnfjörð Bjarmason, May 8, 2011
  15. 14/48 i18n: git-pull die messagesÆvar Arnfjörð Bjarmason, May 8, 2011
  16. 15/48 i18n: git-pull eval_gettext + die messageÆvar Arnfjörð Bjarmason, May 8, 2011
  17. 16/48 i18n: git-pull eval_gettext + warning messageÆvar Arnfjörð Bjarmason, May 8, 2011
  18. Bernhard R. LinkMay 8, 2011
  19. Junio C HamanoMay 8, 2011
  20. 17/48 i18n: git-submodule add git-sh-i18nÆvar Arnfjörð Bjarmason, May 8, 2011
  21. 18/48 i18n: git-submodule echo + eval_gettext messagesÆvar Arnfjörð Bjarmason, May 8, 2011
  22. 19/48 i18n: git-submodule say + eval_gettext messagesÆvar Arnfjörð Bjarmason, May 8, 2011
  23. 20/48 i18n: git-submodule die + eval_gettext messagesÆvar Arnfjörð Bjarmason, May 8, 2011
  24. Johannes SixtMay 12, 2011
  25. Ævar Arnfjörð BjarmasonMay 12, 2011
  26. Johannes SixtMay 12, 2011
  27. Ævar Arnfjörð BjarmasonMay 13, 2011
  28. Erik Faye-LundMay 13, 2011
  29. Ævar Arnfjörð BjarmasonMay 13, 2011
  30. 21/48 i18n: git-submodule $update_module say + die messagesÆvar Arnfjörð Bjarmason, May 8, 2011
  31. 22/48 i18n: git-submodule "cached cannot be used" messageÆvar Arnfjörð Bjarmason, May 8, 2011
  32. 23/48 i18n: git-submodule "Submodule change[...]" messagesÆvar Arnfjörð Bjarmason, May 8, 2011
  33. 24/48 i18n: git-submodule $errmsg messagesÆvar Arnfjörð Bjarmason, May 8, 2011
  34. 25/48 i18n: git-submodule "Entering [...]" messageÆvar Arnfjörð Bjarmason, May 8, 2011
  35. 26/48 i18n: git-submodule "[...] path is ignored" messageÆvar Arnfjörð Bjarmason, May 8, 2011
  36. 27/48 i18n: git-submodule "path not initialized" messageÆvar Arnfjörð Bjarmason, May 8, 2011
  37. 28/48 i18n: git-submodule "blob" and "submodule" messagesÆvar Arnfjörð Bjarmason, May 8, 2011
  38. 29/48 i18n: git-stash add git-sh-i18nÆvar Arnfjörð Bjarmason, May 8, 2011
  39. 30/48 i18n: git-stash echo + gettext messageÆvar Arnfjörð Bjarmason, May 8, 2011
  40. 31/48 i18n: git-stash say + gettext messagesÆvar Arnfjörð Bjarmason, May 8, 2011
  41. 32/48 i18n: git-stash die + gettext messagesÆvar Arnfjörð Bjarmason, May 8, 2011
  42. 33/48 i18n: git-stash die + eval_gettext messagesÆvar Arnfjörð Bjarmason, May 8, 2011
  43. 34/48 i18n: git-stash die + eval_gettext $* messagesÆvar Arnfjörð Bjarmason, May 8, 2011
  44. 35/48 i18n: git-stash die + eval_gettext $1 messagesÆvar Arnfjörð Bjarmason, May 8, 2011
  45. 36/48 i18n: git-stash "unknown option" messageÆvar Arnfjörð Bjarmason, May 8, 2011
  46. Motiejus JakštysMay 8, 2011
  47. Ævar Arnfjörð BjarmasonMay 8, 2011
  48. 37/48 i18n: git-stash drop_stash say/die messagesÆvar Arnfjörð Bjarmason, May 8, 2011
  49. 38/48 i18n: git-bisect add git-sh-i18nÆvar Arnfjörð Bjarmason, May 8, 2011
  50. 39/48 i18n: git-bisect gettext + echo messageÆvar Arnfjörð Bjarmason, May 8, 2011
  51. 40/48 i18n: git-bisect echo + gettext messagesÆvar Arnfjörð Bjarmason, May 8, 2011
  52. 41/48 i18n: git-bisect echo + eval_gettext messageÆvar Arnfjörð Bjarmason, May 8, 2011
  53. 42/48 i18n: git-bisect die + gettext messagesÆvar Arnfjörð Bjarmason, May 8, 2011
  54. 43/48 i18n: git-bisect die + eval_gettext messagesÆvar Arnfjörð Bjarmason, May 8, 2011
  55. 44/48 i18n: git-bisect bisect_run + $@ messagesÆvar Arnfjörð Bjarmason, May 8, 2011
  56. 45/48 i18n: git-bisect bisect_reset + $1 messagesÆvar Arnfjörð Bjarmason, May 8, 2011
  57. 46/48 i18n: git-bisect bisect_replay + $1 messagesÆvar Arnfjörð Bjarmason, May 8, 2011
  58. 47/48 i18n: git-bisect [Y/n] messagesÆvar Arnfjörð Bjarmason, May 8, 2011
  59. 48/48 i18n: git-bisect bisect_next_check "You need to" messageÆvar Arnfjörð Bjarmason, May 8, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.