git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Simplified the invocation of command action in submodule

From
Imran M Yousuf <imyousuf@gmail.com>
Date
Jan 9, 2008, 10:06 UTC
Message-ID
<7bfdc29a0801090206q61150a37i9a4d778a2d416c32@mail.gmail.com>
In-Reply-To
<47849B60.2060000@viscovery.net>
On Jan 9, 2008 4:01 PM, Johannes Sixt <j.sixt@viscovery.net> wrote:
Show 17 quoted lines
> Imran M Yousuf schrieb:
> > On Jan 9, 2008 2:59 PM, Johannes Sixt <j.sixt@viscovery.net> wrote:
> >> - Previously, passing --cached to add, init, or update was an error, now
> >> it is not.
> >
> > The usage statement and this behaviour is rather contradicting. The
> > usage says that --cached can be used with all commands; so I am not
> > sure whether using --cached with add should be an error or not. IMHO,
> > if the previous implementation was right than the USAGE has to be
> > changed, and if the previous implementation was incorrect, than if the
> > default command is set to status than current implementation is right.
>
> I prefer that the usage statement lists one line per sub-command with the
> flags that apply only to the sub-command. IOW, a usage statement that
> suggests that a flag applies to all sub-commands when in reality it
> doesn't is bogus, IMHO.
>

I think for this patch I will keep the usage intact and keep the implementation coherent with the current usage and add a comment in that place so that if required it can be changed in future.

> -- Hannes
>
>
-- 
Imran M Yousuf
Previous: Johannes SixtNext: Junio C Hamano
Message 9 of 12 in “Simplified the invocation of command action in submodule”
  1. Simplified the invocation of command action in submoduleimyousuf@gmail.com, Jan 9, 2008
  2. Junio C HamanoJan 9, 2008
  3. Imran M YousufJan 9, 2008
  4. Johannes SixtJan 9, 2008
  5. Imran M YousufJan 9, 2008
  6. Johannes SixtJan 9, 2008
  7. Imran M YousufJan 9, 2008
  8. Johannes SixtJan 9, 2008
  9. Imran M YousufJan 9, 2008
  10. Junio C HamanoJan 9, 2008
  11. Lars HjemliJan 9, 2008
  12. Imran M YousufJan 10, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.