Re: [PATCH] Simplified the invocation of command action in submodule

From: Imran M Yousuf <imyousuf@gmail.com>
Date: Jan 9, 2008, 08:23 UTC
Message-ID: <7bfdc29a0801090023s437b681ak435f4e31ee649b72@mail.gmail.com>
In-Reply-To: <7vsl17l8bi.fsf@gitster.siamese.dyndns.org>

Hi Junio,

Firstly, $add is still used later in the code. Secondly, yes the variables should be deleted. Will make the change and send the patch again; I forgot to clean the unused variables from the declaration, sorry.

Best regards,

Imran

On Jan 9, 2008 2:19 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 27 quoted lines

> imyousuf@gmail.com writes:
>
> > diff --git a/git-submodule.sh b/git-submodule.sh
> > index ad9fe62..8a29382 100755
> > --- a/git-submodule.sh
> > +++ b/git-submodule.sh
> > @@ -16,6 +16,7 @@ update=
> >  status=
> >  quiet=
> >  cached=
> > +command=
>
> Doesn't the patch make some if not all of the above variables
> unused?
>
> >       case "$1" in
> >       add)
> >               add=1
> > +             command="module_$1"
> >               ;;
> >       init)
> > -             init=1
> > +             command="modules_$1"
> >               ;;
>
> Does the remaining code still use $add?
>

-- 
Imran M Yousuf