Re: [PATCH] Simplified the invocation of command action in submodule

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 9, 2008, 08:19 UTC
Message-ID: <7vsl17l8bi.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1199851140-31853-1-git-send-email-imyousuf@gmail.com>

imyousuf@gmail.com writes:

Show 9 quoted lines

> diff --git a/git-submodule.sh b/git-submodule.sh
> index ad9fe62..8a29382 100755
> --- a/git-submodule.sh
> +++ b/git-submodule.sh
> @@ -16,6 +16,7 @@ update=
>  status=
>  quiet=
>  cached=
> +command=

Doesn't the patch make some if not all of the above variables unused?

Show 9 quoted lines

>  	case "$1" in
>  	add)
>  		add=1
> +		command="module_$1"
>  		;;
>  	init)
> -		init=1
> +		command="modules_$1"
>  		;;

Does the remaining code still use $add?