From: Imran M Yousuf Date: Wed, 09 Jan 2008 10:06:07 GMT Subject: Re: [PATCH] Simplified the invocation of command action in submodule Message-ID: <7bfdc29a0801090206q61150a37i9a4d778a2d416c32@mail.gmail.com> In-Reply-To: <47849B60.2060000@viscovery.net> On Jan 9, 2008 4:01 PM, Johannes Sixt wrote: > Imran M Yousuf schrieb: > > On Jan 9, 2008 2:59 PM, Johannes Sixt wrote: > >> - Previously, passing --cached to add, init, or update was an error, now > >> it is not. > > > > The usage statement and this behaviour is rather contradicting. The > > usage says that --cached can be used with all commands; so I am not > > sure whether using --cached with add should be an error or not. IMHO, > > if the previous implementation was right than the USAGE has to be > > changed, and if the previous implementation was incorrect, than if the > > default command is set to status than current implementation is right. > > I prefer that the usage statement lists one line per sub-command with the > flags that apply only to the sub-command. IOW, a usage statement that > suggests that a flag applies to all sub-commands when in reality it > doesn't is bogus, IMHO. > I think for this patch I will keep the usage intact and keep the implementation coherent with the current usage and add a comment in that place so that if required it can be changed in future. > -- Hannes > > -- Imran M Yousuf