Re: [PATCH v7 0/5] cleanup ra/rebase-i-more-options
On 13/08/2020 18:46, Junio C Hamano wrote:
Show 10 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
>> I offered three small suggestions how I think it could be improved, still,
>> but I would be pretty happy with seeing the patches moving to `next`
>> as-are.
>
> I tend to agree with those points I saw you mentioned.
>
> The unconditional exporting of the committer-date without undoing
> looked like a bad pattern waiting to be copied and pasted.
I think it is copied and pasted from builtin/am.c
> I have not yet fully followed the codepath but I tend to agree with
> your suspicion that commit_tree_extended() might be a better place
> to do this.
It looks like it should be simple enough to do that, I'll reroll
Thanks for your comments dscho
Phillip
> Thanks.
>