Re: [PATCH 1/6] Revert "Revert "Merge branch 'ra/rebase-i-more-options'""
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 7, 2020, 21:04 UTC
- Message-ID
- <xmqqv9mbroqw.fsf@gitster.c.googlers.com>
- In-Reply-To
- <CABPp-BEnmpET=6rEdDXJWnPjzV33a2x6rKB6FQ-o8y+8ssK4jw@mail.gmail.com>
Elijah Newren <newren@gmail.com> writes:
Show 12 quoted lines
> On Tue, Apr 7, 2020 at 7:11 AM Phillip Wood <phillip.wood123@gmail.com> wrote: >> >> From: Phillip Wood <phillip.wood@dunelm.org.uk> >> >> This reverts commit 4d924528d8bfe947abfc54ee9bd3892ab509c8cd. >> >> This is being reverted to enable some fixups for >> ra/rebase-i-more-options to be built on this commit. > > This makes sense to me, but it will be only the second 'Revert > "Revert..."' commit in all of git.git and I'm curious if Junio will be > unhappy with it.
Nah, there isn't much to become unhappy about.
I however suspect that the alternative would certainly be much nicer and easier to understand, which is to rebuild the 7-patch series c58ae96fc4..d82dfa7f5b but bugs already fixed, instead of doing this patch to take us back to a known buggy state and then fix the result with 5 more patches. Is that what you meant?