From: Phillip Wood <phillip.wood123@gmail.com>
Date: Thu, 13 Aug 2020 19:51:50 GMT
Subject: Re: [PATCH v7 0/5] cleanup ra/rebase-i-more-options
Message-ID: <7874298b-3c48-0849-2ee3-8912a410287d@gmail.com>
In-Reply-To: <xmqqzh6y30cf.fsf@gitster.c.googlers.com>

On 13/08/2020 18:46, Junio C Hamano wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
>> I offered three small suggestions how I think it could be improved, still,
>> but I would be pretty happy with seeing the patches moving to `next`
>> as-are.
> 
> I tend to agree with those points I saw you mentioned.
> 
> The unconditional exporting of the committer-date without undoing
> looked like a bad pattern waiting to be copied and pasted. 

I think it is copied and pasted from builtin/am.c

> I have not yet fully followed the codepath but I tend to agree with
> your suspicion that commit_tree_extended() might be a better place
> to do this.

It looks like it should be simple enough to do that, I'll reroll

Thanks for your comments dscho

Phillip

> Thanks.
>