Re: [PATCH] blame: prevent a segv when -L given start > EOF

From: Jay Soffian <jaysoffian@gmail.com>
Date: Feb 9, 2010, 04:09 UTC
Message-ID: <76718491002082009u6a94d628ncf060820d427df7c@mail.gmail.com>
In-Reply-To: <7vtytrrrju.fsf@alter.siamese.dyndns.org>

On Mon, Feb 8, 2010 at 10:55 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 8 quoted lines

> Jay Soffian <jaysoffian@gmail.com> writes:
>
>> -     if (lno < top)
>> +     if (lno < top || lno < bottom)
>>               die("file %s has only %lu lines", path, lno);
>
> Thanks; I think we make sure that "bottom < top" always hold true before
> we reach this point, so checking with bottom alone should suffice, no?

Right, so given "-L 10" at the point of that check:

bottom = 0 top = 10

Whereas given "-L 10,100" at the point of that check:

bottom = 9 top = 100

So the code needs to check both. Previously it made sure neither was < 1, and swapped bottom/top if they were reversed.

Sorry for the confusion.

j.