Re: [PATCH] blame: prevent a segv when -L given start > EOF

From

Johannes Sixt <j.sixt@viscovery.net>

Date

Feb 9, 2010, 07:43 UTC

Message-ID

<4B71122F.3040809@viscovery.net>

In-Reply-To

<1265687293-11168-1-git-send-email-jaysoffian@gmail.com>

Jay Soffian schrieb:

> +test_expect_success 'blame -L with invalid start' '
> +	test_must_fail git blame -L5 tres 2>&1 | grep "has only 2 lines"

Please write this as

	test_must_fail git blame -L5 tres >output 2>&1 &&
	grep "has only 2 lines" output

> +'
> +
> +test_expect_success 'blame -L with invalid end' '
> +	git blame -L1,5 tres 2>&1 | grep "has only 2 lines"

	test_must_fail git blame -L1,5 tres >output 2>&1 &&
	grep "has only 2 lines" output

because shells look only at the exit code of the last command in a pipeline.

-- Hannes