git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t5540-http-push.sh: avoid non-portable grep -P

From
Jay Soffian <jaysoffian@gmail.com>
Date
Feb 26, 2009, 22:40 UTC
Message-ID
<76718490902261440p4c9981fbncbdd58ad12e38349@mail.gmail.com>
In-Reply-To
<7veixkrfif.fsf@gitster.siamese.dyndns.org>
On Thu, Feb 26, 2009 at 5:37 PM, Junio C Hamano <gitster@pobox.com> wrote:
> I don't mind Perl as we already depend on it; the looseness of the regexp
> stil bothers me somewhat, though...

I think you're letting the perfect be the enemy of the good. The point of the test is merely to check for the SHA-1 has suffix in PUT/MOVE operations. Any of my suggestions so far are better than what is there now. Why so much fuss?

I'll send one more iteration, and if that's not good enough, I give up.
j.
Previous: Junio C HamanoNext: Jay Soffian
Message 8 of 17 in “t5540-http-push.sh: avoid non-portable grep -P”
  1. t5540-http-push.sh: avoid non-portable grep -PJay Soffian, Feb 26, 2009
  2. Junio C HamanoFeb 26, 2009
  3. Jay SoffianFeb 26, 2009
  4. Jay SoffianFeb 26, 2009
  5. Junio C HamanoFeb 26, 2009
  6. Jay SoffianFeb 26, 2009
  7. Junio C HamanoFeb 26, 2009
  8. Jay SoffianFeb 26, 2009
  9. t5540-http-push.sh: avoid non-portable grep -PJay Soffian, Feb 26, 2009
  10. Junio C HamanoFeb 26, 2009
  11. Jay SoffianFeb 26, 2009
  12. t5540-http-push.sh: avoid non-portable grep -PJay Soffian, Feb 26, 2009
  13. Brandon CaseyFeb 26, 2009
  14. Johannes SchindelinFeb 26, 2009
  15. Brandon CaseyFeb 27, 2009
  16. Junio C HamanoFeb 27, 2009
  17. t5540-http-push.sh: avoid non-portable grep -PJay Soffian, Feb 26, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.