git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] t5540-http-push.sh: avoid non-portable grep -P

From
Jay Soffian <jaysoffian@gmail.com>
Date
Feb 26, 2009, 19:49 UTC
Message-ID
<1235677745-939-1-git-send-email-jaysoffian@gmail.com>

OS X's GNU grep does not support -P/--perl-regexp; use egrep instead, avoiding non-portable braces ({}) as well.

Signed-off-by: Jay Soffian <jaysoffian@gmail.com>
---
 t/t5540-http-push.sh |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/t/t5540-http-push.sh b/t/t5540-http-push.sh
index 11b3432..6a255a6 100755
--- a/t/t5540-http-push.sh
+++ b/t/t5540-http-push.sh
@@ -94,9 +94,15 @@ test_expect_success 'MKCOL sends directory names with trailing slashes' '
 
 '
 
+x1="[a-z0-9]"
+x2="$x1$x1"
+x5="$x1$x1$x1$x1$x1"
+x38="$x5$x5$x5$x5$x5$x5$x5$x1$x1$x1"
+x40="$x38$x2"
+
 test_expect_success 'PUT and MOVE sends object to URLs with SHA-1 hash suffix' '
 
-	grep -P "\"(?:PUT|MOVE) .+objects/[\da-z]{2}/[\da-z]{38}_[\da-z\-]{40} HTTP/[0-9.]+\" 20\d" \
+	egrep "\"(PUT|MOVE) .+objects/$x2/${x38}_$x40 HTTP/[0-9.]+\" 20[0-9]" \
 		< "$HTTPD_ROOT_PATH"/access.log
 
 '
-- 
1.6.2.rc1.309.g5f417
Next: Junio C Hamano
Message 1 of 17 in “t5540-http-push.sh: avoid non-portable grep -P”
  1. t5540-http-push.sh: avoid non-portable grep -PJay Soffian, Feb 26, 2009
  2. Junio C HamanoFeb 26, 2009
  3. Jay SoffianFeb 26, 2009
  4. Jay SoffianFeb 26, 2009
  5. Junio C HamanoFeb 26, 2009
  6. Jay SoffianFeb 26, 2009
  7. Junio C HamanoFeb 26, 2009
  8. Jay SoffianFeb 26, 2009
  9. t5540-http-push.sh: avoid non-portable grep -PJay Soffian, Feb 26, 2009
  10. Junio C HamanoFeb 26, 2009
  11. Jay SoffianFeb 26, 2009
  12. t5540-http-push.sh: avoid non-portable grep -PJay Soffian, Feb 26, 2009
  13. Brandon CaseyFeb 26, 2009
  14. Johannes SchindelinFeb 26, 2009
  15. Brandon CaseyFeb 27, 2009
  16. Junio C HamanoFeb 27, 2009
  17. t5540-http-push.sh: avoid non-portable grep -PJay Soffian, Feb 26, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.