Re: [PATCH] t5540-http-push.sh: avoid non-portable grep -P

From: Jay Soffian <jaysoffian@gmail.com>
Date: Feb 26, 2009, 23:40 UTC
Message-ID: <76718490902261540m77925a38id628fc3bce2a8667@mail.gmail.com>
In-Reply-To: <7v4oygrd3w.fsf@gitster.siamese.dyndns.org>

On Thu, Feb 26, 2009 at 6:29 PM, Junio C Hamano <gitster@pobox.com> wrote:

> Heh, at least with /a-z/a-f/, I think it is usable.
>
> Or is there a reason I am missing that we want to allow g-z there?

OMG, I didn't even notice that until this message. When you asked:

> Why [a-z0-9] not [0-9a-f]?

I noticed only that you had flipped the relative positions of the alphas and the digits, no that you had also a-z to a-f. Please squash this on top of the last patch I sent:

diff --git a/t/t5540-http-push.sh b/t/t5540-http-push.sh
index 470bca3..bd45203 100755
--- a/t/t5540-http-push.sh
+++ b/t/t5540-http-push.sh
@@ -94,7 +94,7 @@ test_expect_success 'MKCOL sends directory names
with trailing slashes' '

 '

-x1="[0-9a-z]"
+x1="[0-9a-f]"
 x2="$x1$x1"
 x5="$x1$x1$x1$x1$x1"
 x38="$x5$x5$x5$x5$x5$x5$x5$x1$x1$x1"


Sheesh.

j.