From: Jay Soffian Date: Thu, 26 Feb 2009 22:40:25 GMT Subject: Re: [PATCH] t5540-http-push.sh: avoid non-portable grep -P Message-ID: <76718490902261440p4c9981fbncbdd58ad12e38349@mail.gmail.com> In-Reply-To: <7veixkrfif.fsf@gitster.siamese.dyndns.org> On Thu, Feb 26, 2009 at 5:37 PM, Junio C Hamano wrote: > I don't mind Perl as we already depend on it; the looseness of the regexp > stil bothers me somewhat, though... I think you're letting the perfect be the enemy of the good. The point of the test is merely to check for the SHA-1 has suffix in PUT/MOVE operations. Any of my suggestions so far are better than what is there now. Why so much fuss? I'll send one more iteration, and if that's not good enough, I give up. j.