Re: [PATCH 4/7] git-repack: update usage to match docs

From: Derrick Stolee <stolee@gmail.com>
Date: Nov 22, 2024, 15:26 UTC
Message-ID: <6a2f399c-8d65-4d1b-a541-b139d3e8fbf9@gmail.com>
In-Reply-To: <Zz+VRZnWjsDI9bLt@nand.local>

On 11/21/24 3:17 PM, Taylor Blau wrote:

Show 9 quoted lines

> On Tue, Nov 05, 2024 at 03:05:04AM +0000, Derrick Stolee via GitGitGadget wrote:
>> From: Derrick Stolee <stolee@gmail.com>
>>
>> This also adds the '--full-name-hash' option introduced in the previous
>> change and adds newlines to the synopsis.
> 
> I think "the previous change" is not quite accurate here, even if
> you move the implementation to pass through '--full-name-hash' via
> repack into the second patch.

Ah, I should definitely rearrange the commits.

> It would be nice to have the option added in 'repack' in the same commit
> as adjusts the documentation instead of splitting them apart.

Part of the point of the split was that the synopsis in builtin/repack.c needs more than just the addition of the --full-name-hash option in order to make it match the Documentation synopsis.

But you're right, the code change is small enough that these things can be combined.

Thanks, -Stolee