Re: [PATCH 2/7] repack: add --full-name-hash option

From: Derrick Stolee <stolee@gmail.com>
Date: Nov 22, 2024, 12:07 UTC
Message-ID: <5400973a-290f-4fb6-a4cb-28d2effd1d83@gmail.com>
In-Reply-To: <Zz+UJHclSsb+Bgfo@nand.local>

On 11/21/24 3:12 PM, Taylor Blau wrote:

Show 8 quoted lines

> On Tue, Nov 05, 2024 at 03:05:02AM +0000, Derrick Stolee via GitGitGadget wrote:
>> ---
>>   t/t7700-repack.sh       |  7 +++++++
>>   t/test-lib-functions.sh | 26 ++++++++++++++++++++++++++
>>   2 files changed, 33 insertions(+)
> 
> OK, I stand by my thinking in the previous patch that this one is where
> the changes to builtin/repack.c belong.

Yes. I should have done this already.

Show 6 quoted lines

> I do think that test_subcommand_flex may be unnecessary though, since
> you could instead write this as:
> 
>      test_subcommand "git pack-objects.*--full-name-hash" <full-trace.txt
> 
> and get the same behavior.

This does require knowing a bit about the internals of test_subcommand that may be too much of a burden for future contributors.

Thanks, -Stolee