Re: [PATCH 3/7] pack-objects: add GIT_TEST_FULL_NAME_HASH

From: Derrick Stolee <stolee@gmail.com>
Date: Nov 22, 2024, 12:09 UTC
Message-ID: <4c314b69-46b4-402e-a590-78e4f4e0200e@gmail.com>
In-Reply-To: <Zz+U8IyHqBNRIn6m@nand.local>

On 11/21/24 3:15 PM, Taylor Blau wrote:

Show 17 quoted lines

> On Tue, Nov 05, 2024 at 03:05:03AM +0000, Derrick Stolee via GitGitGadget wrote:
>> diff --git a/ci/run-build-and-tests.sh b/ci/run-build-and-tests.sh
>> index 2e28d02b20f..75b40f07bbd 100755
>> --- a/ci/run-build-and-tests.sh
>> +++ b/ci/run-build-and-tests.sh
>> @@ -30,6 +30,7 @@ linux-TEST-vars)
>>   	export GIT_TEST_NO_WRITE_REV_INDEX=1
>>   	export GIT_TEST_CHECKOUT_WORKERS=2
>>   	export GIT_TEST_PACK_USE_BITMAP_BOUNDARY_TRAVERSAL=1
>> +	export GIT_TEST_FULL_NAME_HASH=1
>>   	;;
>>   linux-clang)
>>   	export GIT_TEST_DEFAULT_HASH=sha1
> 
> Hmm. I appreciate what this new GIT_TEST_ variable is trying to do, but
> I am somewhat saddened to see this list in linux-TEST-vars growing
> rather than shrinking.

You make good points that this does not need to be here.

It's enough that someone could manually check the test suite with this test variable to make sure that enough of the other options are tested with this feature.

Thanks, -Stolee