From: Hallvard B Furuseth <h.b.furuseth@usit.uio.no>
Date: Fri, 27 Jan 2012 10:15:10 GMT
Subject: Re: Test t9500 fails if Time::HiRes is missing
Message-ID: <69c90e626682e60d33bebcc6d3ff3fdb@ulrik.uio.no>
In-Reply-To: <CACBZZX4cjcY5d3mPJAV+rbSTqCEUOrF=_dd3ny_jSM++G-Bg1Q@mail.gmail.com>

 On Mon, 23 Jan 2012 10:42:02 +0100, Ævar Arnfjörð Bjarmason 
 <avarab@gmail.com> wrote:
> On Mon, Jan 23, 2012 at 05:50, Hallvard Breien Furuseth
> <h.b.furuseth@usit.uio.no> wrote:
>> Or pacify the test and expect gitweb@RHEL-users to install the RPM:
>>
>> --- git-1.7.9.rc2/t/gitweb-lib.sh~
>> +++ git-1.7.9.rc2/t/gitweb-lib.sh
>> @@ -113,4 +113,9 @@
>>        test_done
>>  }
>>
>> +perl -MTime::HiRes -e 0 >/dev/null 2>&1 || {
>> +       skip_all='skipping gitweb tests, Time::HiRes module not 
>> available'
>> +       test_done
>> +}
>> +
>>  gitweb_init
>
> [Adding Jakub to CC]
>
> This doesn't actually fix the issue, it only sweeps it under the rug
> by making the tests pass, gitweb will still fail to compile on Red
> Hat once installed.

 Is that relevant?  gitweb-lib.sh already has code to pass the tests if
 Encode, CGI, CGI::Util or CGI::Carp are missing.  I just added another.

-- 
 Hallvard