git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v6 09/12] fixup: sha1_file: convert gotos to break/continue

From
JHJeff Hostetler <git@jeffhostetler.com>
Date
Dec 5, 2017, 22:02 UTC
Message-ID
<6952d10c-5f99-e183-548b-e400aed7d49b@jeffhostetler.com>
In-Reply-To
<xmqqk1y0j3p2.fsf@gitster.mtv.corp.google.com>
On 12/5/2017 3:54 PM, Junio C Hamano wrote:
Show 14 quoted lines
> Jeff Hostetler <git@jeffhostetler.com> writes:
> 
>> From: Jeff Hostetler <jeffhost@microsoft.com>
>>
>> Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>
>> ---
>>   sha1_file.c | 40 ++++++++++++++++++++--------------------
>>   1 file changed, 20 insertions(+), 20 deletions(-)
> 
> The second (i.e. this) part and the third part are not yet in
> 'next', so it will perfectly be fine to squash these into the
> commits that introduces the issues that are corrected in this
> "fixup".  The same comment applies to all the other "fixup" patches.
>

OK thanks. I left this one as a separate commit so that we could debate the merits of the while(1) vs the gotos and keep/reject independent of the other changes. I'll squash it in the next version.

Thanks Jeff

Previous: Junio C HamanoNext: Junio C Hamano
Message 14 of 21 in “Partial clone part 2: fsck and promisors”
  1. 00/12 Partial clone part 2: fsck and promisorsJeff Hostetler, Dec 5, 2017
  2. 01/12 extension.partialclone: introduce partial clone extensionJeff Hostetler, Dec 5, 2017
  3. 04/12 fsck: support referenced promisor objectsJeff Hostetler, Dec 5, 2017
  4. 02/12 fsck: introduce partialclone extensionJeff Hostetler, Dec 5, 2017
  5. 05/12 fsck: support promisor objects as CLI argumentJeff Hostetler, Dec 5, 2017
  6. 03/12 fsck: support refs pointing to promisor objectsJeff Hostetler, Dec 5, 2017
  7. Brandon WilliamsDec 7, 2017
  8. Jonathan TanDec 7, 2017
  9. Brandon WilliamsDec 7, 2017
  10. 12/12 gc: do not repack promisor packfilesJeff Hostetler, Dec 5, 2017
  11. 11/12 rev-list: support termination at promisor objectsJeff Hostetler, Dec 5, 2017
  12. 09/12 fixup: sha1_file: convert gotos to break/continueJeff Hostetler, Dec 5, 2017
  13. Junio C HamanoDec 5, 2017
  14. Jeff HostetlerDec 5, 2017
  15. Junio C HamanoDec 5, 2017
  16. Brandon WilliamsDec 7, 2017
  17. 08/12 sha1_file: support lazily fetching missing objectsJeff Hostetler, Dec 5, 2017
  18. 07/12 introduce fetch-object: fetch one promisor objectJeff Hostetler, Dec 5, 2017
  19. 06/12 index-pack: refactor writing of .keep filesJeff Hostetler, Dec 5, 2017
  20. 10/12 fixup: sha1_file: add TODOJeff Hostetler, Dec 5, 2017
  21. Jonathan TanDec 5, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.