From: Jeff Hostetler <git@jeffhostetler.com>
Date: Tue, 05 Dec 2017 22:02:11 GMT
Subject: Re: [PATCH v6 09/12] fixup: sha1_file: convert gotos to break/continue
Message-ID: <6952d10c-5f99-e183-548b-e400aed7d49b@jeffhostetler.com>
In-Reply-To: <xmqqk1y0j3p2.fsf@gitster.mtv.corp.google.com>



On 12/5/2017 3:54 PM, Junio C Hamano wrote:
> Jeff Hostetler <git@jeffhostetler.com> writes:
> 
>> From: Jeff Hostetler <jeffhost@microsoft.com>
>>
>> Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>
>> ---
>>   sha1_file.c | 40 ++++++++++++++++++++--------------------
>>   1 file changed, 20 insertions(+), 20 deletions(-)
> 
> The second (i.e. this) part and the third part are not yet in
> 'next', so it will perfectly be fine to squash these into the
> commits that introduces the issues that are corrected in this
> "fixup".  The same comment applies to all the other "fixup" patches.
> 

OK thanks.  I left this one as a separate commit so that
we could debate the merits of the while(1) vs the gotos
and keep/reject independent of the other changes.  I'll
squash it in the next version.

Thanks
Jeff