git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v6 03/12] fsck: support refs pointing to promisor objects

From
JTJonathan Tan <jonathantanmy@google.com>
Date
Dec 7, 2017, 19:27 UTC
Message-ID
<20171207112726.6486768718085a359bf8deca@google.com>
In-Reply-To
<20171207191852.GC152943@google.com>

On Thu, 7 Dec 2017 11:18:52 -0800 Brandon Williams <bmwill@google.com> wrote:

> Instead of requiring that every test first removes 'repo', maybe you
> want to have each test do its own cleanup by adding in
> 'test_when_finished' lines to do the removals?  Just a thought.

If "test_when_finished" is the style that we plan to use in the project, we can do that.

But I think the "rm -rf" at the beginning of a test method is better than "test_when_finished", though. It makes the test independent (for example, the addition or removal of tests before such a test is less likely to affect that test), and makes it clear if (and how) the test does its own setup as opposed to requiring the setup from another test block.

Previous: Brandon WilliamsNext: Brandon Williams
Message 8 of 21 in “Partial clone part 2: fsck and promisors”
  1. 00/12 Partial clone part 2: fsck and promisorsJeff Hostetler, Dec 5, 2017
  2. 01/12 extension.partialclone: introduce partial clone extensionJeff Hostetler, Dec 5, 2017
  3. 04/12 fsck: support referenced promisor objectsJeff Hostetler, Dec 5, 2017
  4. 02/12 fsck: introduce partialclone extensionJeff Hostetler, Dec 5, 2017
  5. 05/12 fsck: support promisor objects as CLI argumentJeff Hostetler, Dec 5, 2017
  6. 03/12 fsck: support refs pointing to promisor objectsJeff Hostetler, Dec 5, 2017
  7. Brandon WilliamsDec 7, 2017
  8. Jonathan TanDec 7, 2017
  9. Brandon WilliamsDec 7, 2017
  10. 12/12 gc: do not repack promisor packfilesJeff Hostetler, Dec 5, 2017
  11. 11/12 rev-list: support termination at promisor objectsJeff Hostetler, Dec 5, 2017
  12. 09/12 fixup: sha1_file: convert gotos to break/continueJeff Hostetler, Dec 5, 2017
  13. Junio C HamanoDec 5, 2017
  14. Jeff HostetlerDec 5, 2017
  15. Junio C HamanoDec 5, 2017
  16. Brandon WilliamsDec 7, 2017
  17. 08/12 sha1_file: support lazily fetching missing objectsJeff Hostetler, Dec 5, 2017
  18. 07/12 introduce fetch-object: fetch one promisor objectJeff Hostetler, Dec 5, 2017
  19. 06/12 index-pack: refactor writing of .keep filesJeff Hostetler, Dec 5, 2017
  20. 10/12 fixup: sha1_file: add TODOJeff Hostetler, Dec 5, 2017
  21. Jonathan TanDec 5, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.