git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v6 05/12] fsck: support promisor objects as CLI argument

From
JHJeff Hostetler <git@jeffhostetler.com>
Date
Dec 5, 2017, 16:58 UTC
Message-ID
<20171205165854.64979-6-git@jeffhostetler.com>
In-Reply-To
<20171205165854.64979-1-git@jeffhostetler.com>
From: Jonathan Tan <jonathantanmy@google.com>

Teach fsck to not treat missing promisor objects provided on the CLI as an error when extensions.partialclone is set.

Signed-off-by: Jonathan Tan <jonathantanmy@google.com>
---
 builtin/fsck.c           |  2 ++
 t/t0410-partial-clone.sh | 13 +++++++++++++
 2 files changed, 15 insertions(+)
diff --git a/builtin/fsck.c b/builtin/fsck.c
index 4c2a56d..578a7c8 100644
--- a/builtin/fsck.c
+++ b/builtin/fsck.c
@@ -750,6 +750,8 @@ int cmd_fsck(int argc, const char **argv, const char *prefix)
 			struct object *obj = lookup_object(oid.hash);
 
 			if (!obj || !(obj->flags & HAS_OBJ)) {
+				if (is_promisor_object(&oid))
+					continue;
 				error("%s: object missing", oid_to_hex(&oid));
 				errors_found |= ERROR_OBJECT;
 				continue;
diff --git a/t/t0410-partial-clone.sh b/t/t0410-partial-clone.sh
index 4f9931f..e96f436 100755
--- a/t/t0410-partial-clone.sh
+++ b/t/t0410-partial-clone.sh
@@ -125,4 +125,17 @@ test_expect_success 'missing object, but promised, passes fsck' '
 	git -C repo fsck
 '
 
+test_expect_success 'missing CLI object, but promised, passes fsck' '
+	rm -rf repo &&
+	test_create_repo repo &&
+	test_commit -C repo my_commit &&
+
+	A=$(git -C repo commit-tree -m a HEAD^{tree}) &&
+	promise_and_delete "$A" &&
+
+	git -C repo config core.repositoryformatversion 1 &&
+	git -C repo config extensions.partialclone "arbitrary string" &&
+	git -C repo fsck "$A"
+'
+
 test_done
-- 
2.9.3
Previous: Jeff HostetlerNext: Jeff Hostetler
Message 5 of 21 in “Partial clone part 2: fsck and promisors”
  1. 00/12 Partial clone part 2: fsck and promisorsJeff Hostetler, Dec 5, 2017
  2. 01/12 extension.partialclone: introduce partial clone extensionJeff Hostetler, Dec 5, 2017
  3. 04/12 fsck: support referenced promisor objectsJeff Hostetler, Dec 5, 2017
  4. 02/12 fsck: introduce partialclone extensionJeff Hostetler, Dec 5, 2017
  5. 05/12 fsck: support promisor objects as CLI argumentJeff Hostetler, Dec 5, 2017
  6. 03/12 fsck: support refs pointing to promisor objectsJeff Hostetler, Dec 5, 2017
  7. Brandon WilliamsDec 7, 2017
  8. Jonathan TanDec 7, 2017
  9. Brandon WilliamsDec 7, 2017
  10. 12/12 gc: do not repack promisor packfilesJeff Hostetler, Dec 5, 2017
  11. 11/12 rev-list: support termination at promisor objectsJeff Hostetler, Dec 5, 2017
  12. 09/12 fixup: sha1_file: convert gotos to break/continueJeff Hostetler, Dec 5, 2017
  13. Junio C HamanoDec 5, 2017
  14. Jeff HostetlerDec 5, 2017
  15. Junio C HamanoDec 5, 2017
  16. Brandon WilliamsDec 7, 2017
  17. 08/12 sha1_file: support lazily fetching missing objectsJeff Hostetler, Dec 5, 2017
  18. 07/12 introduce fetch-object: fetch one promisor objectJeff Hostetler, Dec 5, 2017
  19. 06/12 index-pack: refactor writing of .keep filesJeff Hostetler, Dec 5, 2017
  20. 10/12 fixup: sha1_file: add TODOJeff Hostetler, Dec 5, 2017
  21. Jonathan TanDec 5, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.