Re: [PATCH v3 0/5] am/rebase: share read_author_script()

From: Phillip Wood <phillip.wood@talktalk.net>
Date: Oct 31, 2018, 10:14 UTC
Message-ID: <5f778c2b-6344-32be-91d1-65c50860032a@talktalk.net>
In-Reply-To: <xmqqbm7azv5r.fsf@gitster-ct.c.googlers.com>

On 31/10/2018 02:50, Junio C Hamano wrote:

Show 9 quoted lines

> Phillip Wood <phillip.wood@talktalk.net> writes:
> 
>> From: Phillip Wood <phillip.wood@dunelm.org.uk>
>>
>> Thanks to Junio for the feedback on v2. I've updated patch 4 based on
>> those comments, the rest are unchanged.
> 
> Hmph, all these five patches seem to be identical to what I have in
> 'pu'.  Did you send the right version?

Oh dear that's embarrassing. I updated the patches on my laptop and forget to sync before sending them from my desktop. I'll send v4 now.

Sorry for the confusion

Phillip

Show 19 quoted lines

> 
>> v1 cover letter:
>>
>> This is a follow up to pw/rebase-i-author-script-fix, it reduces code
>> duplication and improves rebase's parsing of the author script. After
>> this I'll do another series to share the code to write the author
>> script.
>>
>> Phillip Wood (5):
>>   am: don't die in read_author_script()
>>   am: improve author-script error reporting
>>   am: rename read_author_script()
>>   add read_author_script() to libgit
>>   sequencer: use read_author_script()
>>
>>  builtin/am.c |  60 ++--------------
>>  sequencer.c  | 192 ++++++++++++++++++++++++++++++++-------------------
>>  sequencer.h  |   3 +
>>  3 files changed, 128 insertions(+), 127 deletions(-)