git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] test-lib: ulimit does not limit on CYGWIN and MINGW

From
Ramsay Jones <ramsay@ramsayjones.plus.com>
Date
Sep 14, 2017, 17:31 UTC
Message-ID
<5b0fcb15-cb02-92e4-29a9-39f45eda1786@ramsayjones.plus.com>
In-Reply-To
<00b6d2a5508520635956da1d2db656bca126cd1a.1505400392.git.git@grubix.eu>
On 14/09/17 15:52, Michael J Gruber wrote:
Show 18 quoted lines
> ulimit succeeds (by return value) but does not limit on some systems.
> 
> Set ulimit() to false on these systems so that we do not rely on its
> output nor effect. As an intended side-effect, ulimit based
> prerequisites are set correctly (to "not-have") on these systems.
> 
> Reported-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> Reported-by: Adam Dinwoodie <adam@dinwoodie.org>
> Reported-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
> Signed-off-by: Michael J Gruber <git@grubix.eu>
> ---
> This is independent of my series, but should best go before so that no
> ulimit based test is run on CYGWIN and MINGW.
> 
> It follows the basic assumption that a tool like ulimit is either
> present and functional or not present; and that we work around by
> defines or such when that assumption is broken.
> (Alternatively, we could set ULIMT_LIMITS or so and depend on that.)

Heh, this was my first suggestion, if you recall, but I decided to go a different way ... ;-)

Also, Johannes made a good suggestion, which lead to a new version of my patch (which could easily be extended to cover the FIFO).

I don't have a strong preference for either approach (but I would have to test your patches, which I haven't done yet), so I would be happy to see either applied.

ATB, Ramsay Jones

Previous: Michael J Gruber
Message 11 of 11 in “test-lib: don't use ulimit in test prerequisites on cygwin”
  1. test-lib: don't use ulimit in test prerequisites on cygwinRamsay Jones, Sep 13, 2017
  2. Jonathan NiederSep 13, 2017
  3. Michael J GruberSep 14, 2017
  4. Johannes SchindelinSep 14, 2017
  5. 1/2 test-lib: group system specific FIFO tests by systemMichael J Gruber, Sep 14, 2017
  6. Johannes SchindelinSep 14, 2017
  7. Michael J GruberSep 15, 2017
  8. Ramsay JonesSep 15, 2017
  9. Johannes SchindelinSep 15, 2017
  10. 2/2 test-lib: ulimit does not limit on CYGWIN and MINGWMichael J Gruber, Sep 14, 2017
  11. Ramsay JonesSep 14, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.