Re: [PATCH] test-lib: don't use ulimit in test prerequisites on cygwin

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Sep 13, 2017, 19:20 UTC
Message-ID: <20170913192038.GH27425@aiede.mtv.corp.google.com>
In-Reply-To: <b57731ed-4640-d27f-f7b2-6c70af8dd400@ramsayjones.plus.com>

Ramsay Jones wrote:

Show 17 quoted lines

> On cygwin (and MinGW), the 'ulimit' built-in bash command does not have
> the desired effect of limiting the resources of new processes, at least
> for the stack and file descriptors. However, it always returns success
> and leads to several test prerequisites being erroneously set to true.
>
> Add a check for cygwin and MinGW to the prerequisite expressions, using
> 'uname -s', and return false instead of (indirectly) using 'ulimit'.
> This affects the prerequisite expressions for the ULIMIT_STACK_SIZE,
> CMDLINE_LIMIT and ULIMIT_FILE_DESCRIPTORS prerequisites.
>
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>  t/t1400-update-ref.sh | 11 ++++++++++-
>  t/t6120-describe.sh   |  1 -
>  t/t7004-tag.sh        |  1 -
>  t/test-lib.sh         | 22 ++++++++++++++++++++--
>  4 files changed, 30 insertions(+), 5 deletions(-)

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks.

An alternative would be to do some more explicit feature-based test like using "ulimit" to set a limit and then reading back the limit in a separate process, but that feels like overkill.

Sincerely, Jonathan