From: Ramsay Jones Date: Thu, 14 Sep 2017 17:31:06 GMT Subject: Re: [PATCH 2/2] test-lib: ulimit does not limit on CYGWIN and MINGW Message-ID: <5b0fcb15-cb02-92e4-29a9-39f45eda1786@ramsayjones.plus.com> In-Reply-To: <00b6d2a5508520635956da1d2db656bca126cd1a.1505400392.git.git@grubix.eu> On 14/09/17 15:52, Michael J Gruber wrote: > ulimit succeeds (by return value) but does not limit on some systems. > > Set ulimit() to false on these systems so that we do not rely on its > output nor effect. As an intended side-effect, ulimit based > prerequisites are set correctly (to "not-have") on these systems. > > Reported-by: Ramsay Jones > Reported-by: Adam Dinwoodie > Reported-by: Johannes Schindelin > Signed-off-by: Michael J Gruber > --- > This is independent of my series, but should best go before so that no > ulimit based test is run on CYGWIN and MINGW. > > It follows the basic assumption that a tool like ulimit is either > present and functional or not present; and that we work around by > defines or such when that assumption is broken. > (Alternatively, we could set ULIMT_LIMITS or so and depend on that.) Heh, this was my first suggestion, if you recall, but I decided to go a different way ... ;-) Also, Johannes made a good suggestion, which lead to a new version of my patch (which could easily be extended to cover the FIFO). I don't have a strong preference for either approach (but I would have to test your patches, which I haven't done yet), so I would be happy to see either applied. ATB, Ramsay Jones