Re: [PATCH 1/2] test-lib: group system specific FIFO tests by system
- From
Michael J Gruber <git@grubix.eu>
- Date
- Sep 15, 2017, 10:31 UTC
- Message-ID
- <a159230a-d406-c772-13f0-f82a36faf763@grubix.eu>
- In-Reply-To
- <alpine.DEB.2.21.1.1709150020070.219280@virtualbox>
Johannes Schindelin venit, vidit, dixit 15.09.2017 00:21:
Show 15 quoted lines
> Hi Michael, > > On Thu, 14 Sep 2017, Michael J Gruber wrote: > >> test-lib determines whether a file-system supports FIFOs and needs to do >> special casing for CYGWIN and MINGW. This separates those system >> specific settings from those at more central place. >> >> Set mkfifo() to false in the central system specific place so that the >> same test works everywhere. > > The mkfifo() emulation of Cygwin seems to work, no? I think it works even > in MSYS2, but not in MINGW. > > So maybe this patch should affect only the MINGW arm?
I only reorganised the code, so in that sense the patch does not affect any system ;)
If indeed mkfifo works on CYGWIN than a separate patch should remove the exclusion of CYGWIN; alas, I can't confirm (I wish MS still had the old academic alliance programme).
Michael