git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 2/8] status: cleanup API to wt_status_print

From
JHJeff Hostetler <git@jeffhostetler.com>
Date
Aug 4, 2016, 12:35 UTC
Message-ID
<57A33682.9080305@jeffhostetler.com>
In-Reply-To
<xmqqr3a57cxm.fsf@gitster.mtv.corp.google.com>
On 08/03/2016 05:36 PM, Junio C Hamano wrote:
Show 28 quoted lines
> Jeff Hostetler <git@jeffhostetler.com> writes:
>
>> From: Jeff Hostetler <jeffhost@microsoft.com>
>> diff --git a/wt-status.h b/wt-status.h
>> index 2023a3c..a859a12 100644
>> --- a/wt-status.h
>> +++ b/wt-status.h
>> @@ -43,6 +43,15 @@ struct wt_status_change_data {
>>   	unsigned new_submodule_commits : 1;
>>   };
>>
>> + enum wt_status_format {
>> +	STATUS_FORMAT_NONE = 0,
>> +	STATUS_FORMAT_LONG,
>> +	STATUS_FORMAT_SHORT,
>> +	STATUS_FORMAT_PORCELAIN,
>> +
>> +	STATUS_FORMAT_UNSPECIFIED
>> + };
>
> Is it your editor, or is it your MUA?  This definition is indented
> by one SP, which is funny.
>
> Also throughout the series, I saw a handful of blank lines that
> should be empty but are not (e.g. three tabs and nothing else on a
> new line).  I've fixed them up all but I won't be sending an
> interdiff just for them, so please make sure they won't resurface
> when/if you reroll.

That's odd. I'll double check everything and trim them in case I need to resubmit this. Sorry.

Jeff
Previous: Junio C HamanoNext: Jeff Hostetler
Message 4 of 31 in “status: V2 porcelain status”
  1. 0/8 status: V2 porcelain statusJeff Hostetler, Aug 2, 2016
  2. 2/8 status: cleanup API to wt_status_printJeff Hostetler, Aug 2, 2016
  3. Junio C HamanoAug 3, 2016
  4. Jeff HostetlerAug 4, 2016
  5. 3/8 status: support --porcelain[=<version>]Jeff Hostetler, Aug 2, 2016
  6. Junio C HamanoAug 3, 2016
  7. 8/8 status: tests for --porcelain=v2Jeff Hostetler, Aug 2, 2016
  8. Junio C HamanoAug 5, 2016
  9. Jeff HostetlerAug 5, 2016
  10. 6/8 status: print branch info with --porcelain=v2 --branchJeff Hostetler, Aug 2, 2016
  11. Junio C HamanoAug 5, 2016
  12. Jeff HostetlerAug 5, 2016
  13. 5/8 status: print per-file porcelain v2 status dataJeff Hostetler, Aug 2, 2016
  14. Jeff KingAug 5, 2016
  15. Junio C HamanoAug 5, 2016
  16. Jeff KingAug 5, 2016
  17. Junio C HamanoAug 5, 2016
  18. Stefan BellerAug 5, 2016
  19. Stefan BellerAug 5, 2016
  20. Jeff HostetlerAug 5, 2016
  21. 7/8 git-status.txt: describe --porcelain=v2 formatJeff Hostetler, Aug 2, 2016
  22. Junio C HamanoAug 5, 2016
  23. Jeff HostetlerAug 5, 2016
  24. 1/8 status: rename long-format print routinesJeff Hostetler, Aug 2, 2016
  25. Junio C HamanoAug 3, 2016
  26. Jeff HostetlerAug 4, 2016
  27. 4/8 status: per-file data collection for --porcelain=v2Jeff Hostetler, Aug 2, 2016
  28. Johannes SchindelinAug 3, 2016
  29. Junio C HamanoAug 3, 2016
  30. Johannes SchindelinAug 3, 2016
  31. Junio C HamanoAug 3, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.