From: Jeff Hostetler <git@jeffhostetler.com>
Date: Thu, 04 Aug 2016 12:35:14 GMT
Subject: Re: [PATCH v4 2/8] status: cleanup API to wt_status_print
Message-ID: <57A33682.9080305@jeffhostetler.com>
In-Reply-To: <xmqqr3a57cxm.fsf@gitster.mtv.corp.google.com>



On 08/03/2016 05:36 PM, Junio C Hamano wrote:
> Jeff Hostetler <git@jeffhostetler.com> writes:
>
>> From: Jeff Hostetler <jeffhost@microsoft.com>
>> diff --git a/wt-status.h b/wt-status.h
>> index 2023a3c..a859a12 100644
>> --- a/wt-status.h
>> +++ b/wt-status.h
>> @@ -43,6 +43,15 @@ struct wt_status_change_data {
>>   	unsigned new_submodule_commits : 1;
>>   };
>>
>> + enum wt_status_format {
>> +	STATUS_FORMAT_NONE = 0,
>> +	STATUS_FORMAT_LONG,
>> +	STATUS_FORMAT_SHORT,
>> +	STATUS_FORMAT_PORCELAIN,
>> +
>> +	STATUS_FORMAT_UNSPECIFIED
>> + };
>
> Is it your editor, or is it your MUA?  This definition is indented
> by one SP, which is funny.
>
> Also throughout the series, I saw a handful of blank lines that
> should be empty but are not (e.g. three tabs and nothing else on a
> new line).  I've fixed them up all but I won't be sending an
> interdiff just for them, so please make sure they won't resurface
> when/if you reroll.

That's odd.  I'll double check everything and trim
them in case I need to resubmit this.  Sorry.

Jeff