Re: [PATCH v4 1/8] status: rename long-format print routines

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 3, 2016, 21:28 UTC
Message-ID: <xmqqvazh7dam.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1470147137-17498-2-git-send-email-git@jeffhostetler.com>

Jeff Hostetler <git@jeffhostetler.com> writes:

Show 6 quoted lines

> From: Jeff Hostetler <jeffhost@microsoft.com>
>
> Renamed the various wt_status_print*() routines to be
> wt_longstatus_print*() to make it clear that these
> routines are only concerned with the normal/long
> status output.

We tend to write "Rename the various...", as if you the patch author is giving an order to "become so" to the codebase, or "make it so" to the maintainer.

Other than that, this step looks straight-forward, and I agree with the hope that this will reduce confusion that readers may have while reading a future version of this code.

Show 5 quoted lines

> This will hopefully reduce confusion as other status
> formats are added in the future.
>
> Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>
> Signed-off-by: Jeff Hostetler <git@jeffhostetler.com>

Hmm, are these physically the same people? If so, which one do you want to be known as?

Thanks.