Re: [PATCH] strbuf: use designated initializers in STRBUF_INIT

From: Johannes Sixt <j6t@kdbg.org>
Date: Jul 11, 2017, 05:24 UTC
Message-ID: <577e31a0-ecb2-d0a0-b259-b65b31116be8@kdbg.org>
In-Reply-To: <20170711000540.4tdytyiit27trmzo@genre.crustytoothpaste.net>

Am 11.07.2017 um 02:05 schrieb brian m. carlson:

Show 8 quoted lines

> On Mon, Jul 10, 2017 at 09:57:40PM +0200, Johannes Sixt wrote:
>> It's a pity, though, that you do not suggest something even more useful,
>> such as C++14.
> 
> I have tried compiling Git with a C++ compiler, so that I could test
> whether that was a viable alternative for MSVC in case its C++ mode
> supported features its C mode did not.  Let's just say that the
> compilation aborted very quickly and I gave up after a few minutes.

It's 3 cleanup patches and one hacky patch with this size:

  80 files changed, 899 insertions(+), 807 deletions(-)

to compile with C++. It passed the test suite last time I tried. Getting rid of the remaining 1000+ -fpermissive warnings is a different matter, though.

I can revive the patches if there is interest.

-- Hannes