Re: [PATCH] strbuf: use designated initializers in STRBUF_INIT
- From
brian m. carlson <sandals@crustytoothpaste.net>
- Date
- Jul 12, 2017, 01:26 UTC
- Message-ID
- <20170712012631.o7jdced5hqkqzug2@genre.crustytoothpaste.net>
- In-Reply-To
- <577e31a0-ecb2-d0a0-b259-b65b31116be8@kdbg.org>
On Tue, Jul 11, 2017 at 07:24:07AM +0200, Johannes Sixt wrote:
Show 12 quoted lines
> Am 11.07.2017 um 02:05 schrieb brian m. carlson: > > I have tried compiling Git with a C++ compiler, so that I could test > > whether that was a viable alternative for MSVC in case its C++ mode > > supported features its C mode did not. Let's just say that the > > compilation aborted very quickly and I gave up after a few minutes. > > It's 3 cleanup patches and one hacky patch with this size: > > 80 files changed, 899 insertions(+), 807 deletions(-) > > to compile with C++. It passed the test suite last time I tried. Getting rid > of the remaining 1000+ -fpermissive warnings is a different matter, though.
Yeah, that's the size I was thinking. My goal was "easily achievable in half an hour," which it didn't seem like at the time.
> I can revive the patches if there is interest.
I'd be interested in at least a pointer to them if you have one. I think it might allow us to take advantage of desirable features that are in the intersection of C99 and C++.
-- brian m. carlson / brian with sandals: Houston, Texas, US https://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: https://keybase.io/bk2204