Re: [PATCH] objects: scope count variable to loop

From: Jeff King <peff@peff.net>
Date: Jul 24, 2017, 18:05 UTC
Message-ID: <20170724180530.smcjifvwytc5wcwa@sigill.intra.peff.net>
In-Reply-To: <CAGZ79kZafHBJOVwZzw_ii3T6_X24Uci4vUudp45r8-GTn0a4Sg@mail.gmail.com>

On Mon, Jul 24, 2017 at 10:12:59AM -0700, Stefan Beller wrote:

Show 12 quoted lines

> > Interestingly I have no problems compiling it here. I wonder if Stefan's
> > config.mak is supplying -std=c89 or some other restrictive flag. Or if
> > his compiler is a different version (though I tried with gcc-6, gcc-4.9,
> > and clang-3.8).
> 
> Before this patch, I only had
>   CFLAGS += -g -O0
> in config.mak (as I switched working directories recently), I'll throw in
>   DEVELOPER=1
> 
> My compiler version is ancient (gcc 4.8.4-2ubuntu1~14.04.3)
> apparently (why did I never check in this environment?)

Ah, indeed, it's the compiler version. And I actually screwed up my gcc-4.9 test. It complains, too. It looks like the default for gcc bumped from gnu90 to gnu11 in gcc 5.

-Peff