Re: [PATCH] objects: scope count variable to loop

From: Jeff King <peff@peff.net>
Date: Jul 24, 2017, 17:08 UTC
Message-ID: <20170724170813.scceigybl5d3fvdd@sigill.intra.peff.net>
In-Reply-To: <20170719182342.GA158344@google.com>

On Wed, Jul 19, 2017 at 11:23:42AM -0700, Brandon Williams wrote:

Show 9 quoted lines

> > object.c: In function ‘object_array_remove_duplicates’:
> > object.c:404:2: error: ‘for’ loop initial declarations are only allowed in C99 mode
> >   for (unsigned src = 0; src < nr; src++) {
> >   ^
> > object.c:404:2: note: use option -std=c99 or -std=gnu99 to compile your code
> > 
> > Using -std=c99 works for me.
> 
> This would need a change to the makefile then wouldn't it?

Actually, it complicates things even more, I'd think. We probably can't just blindly add "-std=c99" to CFLAGS, as not all compilers would support it (even if they _do_ support this construct).

Interestingly I have no problems compiling it here. I wonder if Stefan's config.mak is supplying -std=c89 or some other restrictive flag. Or if his compiler is a different version (though I tried with gcc-6, gcc-4.9, and clang-3.8).

-Peff