git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [WIP/RFH/PATCH 3/3] t/lib-git-svn: adjust config to apache 2.4

From
Michael J Gruber <git@drmicha.warpmail.net>
Date
Apr 13, 2015, 10:14 UTC
Message-ID
<552B96F5.8060607@drmicha.warpmail.net>
In-Reply-To
<20150410033953.GC11280@peff.net>
Jeff King venit, vidit, dixit 10.04.2015 05:39:
Show 14 quoted lines
> On Fri, Apr 10, 2015 at 05:23:17AM +0200, Jeff King wrote:
> 
>> Curiously, though, the git-svn tests seem to run fine for me on Apache
>> 2.4 without your patch. I wonder if the fixes I mentioned above (which I
>> definitely needed to get the regular http tests running on Debian back
>> then) are not necessary on my system anymore (e.g., because the apache2
>> package now ships with better-compatible config).
> 
> Ah, I see. I am not in fact running apache.
> 
> If you do not set SVN_HTTPD_PORT (which I don't), then lib-git-svn.sh's
> start_httpd silently returns success without bothering to setup the
> apache server at all. And yet the rest of the tests run to completion
> just fine.
Yep.
> It looks like setting this variable is a way to say "run the same set of
> tests, but do it over svn-over-httpd instead of svn's direct filesystem
> access". Setting SVN_HTTPD_PORT does cause the tests to fail for me.
Oh, I didn't even notice that. That's a bit weird.
Show 11 quoted lines
> I don't know how important it is to run these tests over httpd. If so,
> it would be nice to do something like lib-httpd does: try the apache
> setup by default, and if it fails, gracefully skip the tests (or
> fallback to the non-httpd version).
> 
> I'm also not sure if there's value in running both the httpd and
> local-filesystem forms of the test. IOW, should we be factoring out the
> tests and having two separate scripts that set $svnrepo as appropriate,
> and then runs the tests?
> 
> -Peff

Hmm, if those tests are run (with file://) I'm inclined to leave things as they are (scratch 3/3)... Though the fact that on my system, lib-git-svn starts the server but fails to connect isn't overly comforting. But git-svn is being used less and less. World domination is almost complete.

Michael
Previous: Jeff KingNext: Kyle J. McKay
Message 10 of 19 in “Make httpd tests run”
  1. 0/3 Make httpd tests runMichael J Gruber, Apr 8, 2015
  2. 1/3 t/lib-httpd: load mod_unixdMichael J Gruber, Apr 8, 2015
  3. 2/3 t/lib-git-svn: check same httpd module dirs as lib-httpdMichael J Gruber, Apr 8, 2015
  4. 3/3 t/lib-git-svn: adjust config to apache 2.4Michael J Gruber, Apr 8, 2015
  5. Eric WongApr 8, 2015
  6. Michael J GruberApr 9, 2015
  7. Eric WongApr 9, 2015
  8. Jeff KingApr 10, 2015
  9. Jeff KingApr 10, 2015
  10. Michael J GruberApr 13, 2015
  11. Kyle J. McKayApr 9, 2015
  12. Kyle J. McKayApr 9, 2015
  13. 0/4 Make httpd tests run v2Michael J Gruber, May 11, 2015
  14. 1/4 t/lib-httpd: load mod_unixdMichael J Gruber, May 11, 2015
  15. 2/4 t/lib-git-svn: check same httpd module dirs as lib-httpdMichael J Gruber, May 11, 2015
  16. 3/4 t/t91*: do not say how to avoid the testsMichael J Gruber, May 11, 2015
  17. 4/4 t/lib-git-svn: adjust config to apache 2.4 WIPMichael J Gruber, May 11, 2015
  18. Michael J GruberApr 9, 2015
  19. Jeff KingApr 10, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.