git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [WIP/RFH/PATCH 3/3] t/lib-git-svn: adjust config to apache 2.4

From
Jeff King <peff@peff.net>
Date
Apr 10, 2015, 03:23 UTC
Message-ID
<20150410032317.GB11280@peff.net>
In-Reply-To
<0631c09d394dedb803a100e81ce4052a57b4e73e.1428505184.git.git@drmicha.warpmail.net>
On Wed, Apr 08, 2015 at 05:05:26PM +0200, Michael J Gruber wrote:
> The current config is tailored to apache 2.2. Apache 2.4 fails to start
> with it.
> 
> Adjust the config to apache 2.4.

I think this needs more conditional config. See the similar fixes I did in:

  296f0b3 (t/lib-httpd/apache.conf: configure an MPM module for apache
  2.4, 2013-06-09)
and:
  0442743 (t/lib-httpd/apache.conf: do not use LockFile in apache >=
  2.4, 2013-06-09)
And also beware of the ordering problem fixed by:
  5bdc47e (lib-httpd/apache.conf: check version only after mod_version
  loads, 2013-06-21)

Curiously, though, the git-svn tests seem to run fine for me on Apache 2.4 without your patch. I wonder if the fixes I mentioned above (which I definitely needed to get the regular http tests running on Debian back then) are not necessary on my system anymore (e.g., because the apache2 package now ships with better-compatible config).

>     Again, I'm wondering who is running these tests at all, but also:

I run the http tests regularly (and have for a long time). I don't usually run the svn tests, though.

>     Why do we leverage lib-httpd so little from lib-git-svn?

I don't mind us doing the minimal work here to bring the svn tests to a working state for your platform. As Eric mentions, refactoring test infrastructure is boring and thankless work. :)

But an alternate solution for patches 2 and 3 might be to share more of the startup code and config between the two. I don't know how painful that would be. From a cursory look, I think t/lib-httpd/apache.conf would have to get split into two parts: one to get apache running at all, and one to setup the <Location> and other bits related directly to the http tests.

-Peff
Previous: Eric WongNext: Jeff King
Message 8 of 19 in “Make httpd tests run”
  1. 0/3 Make httpd tests runMichael J Gruber, Apr 8, 2015
  2. 1/3 t/lib-httpd: load mod_unixdMichael J Gruber, Apr 8, 2015
  3. 2/3 t/lib-git-svn: check same httpd module dirs as lib-httpdMichael J Gruber, Apr 8, 2015
  4. 3/3 t/lib-git-svn: adjust config to apache 2.4Michael J Gruber, Apr 8, 2015
  5. Eric WongApr 8, 2015
  6. Michael J GruberApr 9, 2015
  7. Eric WongApr 9, 2015
  8. Jeff KingApr 10, 2015
  9. Jeff KingApr 10, 2015
  10. Michael J GruberApr 13, 2015
  11. Kyle J. McKayApr 9, 2015
  12. Kyle J. McKayApr 9, 2015
  13. 0/4 Make httpd tests run v2Michael J Gruber, May 11, 2015
  14. 1/4 t/lib-httpd: load mod_unixdMichael J Gruber, May 11, 2015
  15. 2/4 t/lib-git-svn: check same httpd module dirs as lib-httpdMichael J Gruber, May 11, 2015
  16. 3/4 t/t91*: do not say how to avoid the testsMichael J Gruber, May 11, 2015
  17. 4/4 t/lib-git-svn: adjust config to apache 2.4 WIPMichael J Gruber, May 11, 2015
  18. Michael J GruberApr 9, 2015
  19. Jeff KingApr 10, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.