git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [WIP/RFH/PATCH 3/3] t/lib-git-svn: adjust config to apache 2.4

From
Michael J Gruber <git@drmicha.warpmail.net>
Date
Apr 9, 2015, 09:33 UTC
Message-ID
<55264763.6050703@drmicha.warpmail.net>
In-Reply-To
<20150408202615.GA12154@dcvr.yhbt.net>
Eric Wong venit, vidit, dixit 08.04.2015 22:26:
Show 11 quoted lines
> Michael J Gruber <git@drmicha.warpmail.net> wrote:
>> The current config is tailored to apache 2.2. Apache 2.4 fails to start
>> with it.
>>
>> Adjust the config to apache 2.4.
>>
>> Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
>> ---
> 
> 1/3 and 2/3 tested fine on Debian stable (wheezy).
> You can add my Tested-by to 1/3 and my S-o-b to 2/3.
Thanks, that's good to know.
Show 11 quoted lines
> ...but not this one.
> 
>> Notes:
>>     This is WIP and RFH. Apache does not start without mpm, and the lock
>>     mechanism has changed. It will run with these changes, but svn fails to
>>     connect.
>>     
>>     Again, I'm wondering who is running these tests at all, but also:
>>     Why do we leverage lib-httpd so little from lib-git-svn?
> 
> I'm only testing on Apache 2.2 (from Debian stable (wheezy)).

So debian stable has apache 2.2? That explains why many don't see these problems.

Show 5 quoted lines
> I doubt anybody here, myself included, likes dealing with SVN,
> and would rather ignore the tests than try to fix them.
> 
> lib-git-svn predates lib-httpd, and it isn't very interesting work
> to port and cleanup.

I agree with everything above. But if (and that's a big if) the tests don't run for anyone I'd rather remove them if there's no way to port them.

Show 6 quoted lines
>> +LoadModule mpm_prefork_module $SVN_HTTPD_MODULE_PATH/mod_mpm_prefork.so
> 
> I think you need an IfModule guard around this?
> 
> I have no mod_mpm_prefork.so file with the apache2-mpm-prefork
> (2.2.22-13+deb7u4) package on Debian wheezy.

Sure, the changes in 3/3 are for apache 2.4 only and should be guarded by a version check the same way as the ones in lib-httpd.

I'm just trying to figure out how to run them at all first.

So, before 3/3, t9118 and such do run the web server and test git-svn against that for you?

Michael
Previous: Eric WongNext: Eric Wong
Message 6 of 19 in “Make httpd tests run”
  1. 0/3 Make httpd tests runMichael J Gruber, Apr 8, 2015
  2. 1/3 t/lib-httpd: load mod_unixdMichael J Gruber, Apr 8, 2015
  3. 2/3 t/lib-git-svn: check same httpd module dirs as lib-httpdMichael J Gruber, Apr 8, 2015
  4. 3/3 t/lib-git-svn: adjust config to apache 2.4Michael J Gruber, Apr 8, 2015
  5. Eric WongApr 8, 2015
  6. Michael J GruberApr 9, 2015
  7. Eric WongApr 9, 2015
  8. Jeff KingApr 10, 2015
  9. Jeff KingApr 10, 2015
  10. Michael J GruberApr 13, 2015
  11. Kyle J. McKayApr 9, 2015
  12. Kyle J. McKayApr 9, 2015
  13. 0/4 Make httpd tests run v2Michael J Gruber, May 11, 2015
  14. 1/4 t/lib-httpd: load mod_unixdMichael J Gruber, May 11, 2015
  15. 2/4 t/lib-git-svn: check same httpd module dirs as lib-httpdMichael J Gruber, May 11, 2015
  16. 3/4 t/t91*: do not say how to avoid the testsMichael J Gruber, May 11, 2015
  17. 4/4 t/lib-git-svn: adjust config to apache 2.4 WIPMichael J Gruber, May 11, 2015
  18. Michael J GruberApr 9, 2015
  19. Jeff KingApr 10, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.