Re: [WIP/RFH/PATCH 3/3] t/lib-git-svn: adjust config to apache 2.4
- From
- Eric Wong <normalperson@yhbt.net>
- Date
- Apr 8, 2015, 20:26 UTC
- Message-ID
- <20150408202615.GA12154@dcvr.yhbt.net>
- In-Reply-To
- <0631c09d394dedb803a100e81ce4052a57b4e73e.1428505184.git.git@drmicha.warpmail.net>
Michael J Gruber <git@drmicha.warpmail.net> wrote:
Show 7 quoted lines
> The current config is tailored to apache 2.2. Apache 2.4 fails to start > with it. > > Adjust the config to apache 2.4. > > Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net> > ---
1/3 and 2/3 tested fine on Debian stable (wheezy). You can add my Tested-by to 1/3 and my S-o-b to 2/3.
...but not this one.
Show 7 quoted lines
> Notes: > This is WIP and RFH. Apache does not start without mpm, and the lock > mechanism has changed. It will run with these changes, but svn fails to > connect. > > Again, I'm wondering who is running these tests at all, but also: > Why do we leverage lib-httpd so little from lib-git-svn?
I'm only testing on Apache 2.2 (from Debian stable (wheezy)).
I doubt anybody here, myself included, likes dealing with SVN, and would rather ignore the tests than try to fix them.
lib-git-svn predates lib-httpd, and it isn't very interesting work to port and cleanup.
> +LoadModule mpm_prefork_module $SVN_HTTPD_MODULE_PATH/mod_mpm_prefork.so
I think you need an IfModule guard around this?
I have no mod_mpm_prefork.so file with the apache2-mpm-prefork (2.2.22-13+deb7u4) package on Debian wheezy.