git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] Breaking the ref-transactions-reflog series in smaller parts

From
Michael Haggerty <mhagger@alum.mit.edu>
Date
Nov 20, 2014, 11:03 UTC
Message-ID
<546DCA85.8060806@alum.mit.edu>
In-Reply-To
<1416433224-29763-1-git-send-email-sbeller@google.com>
On 11/19/2014 10:40 PM, Stefan Beller wrote:
Show 11 quoted lines
> so I think the patch series ref-transactions-reflog[1] sent previously to the list
> is still too large for easy review and I want to break it up more.
> So in this series we'll digest only 2 small patches, which do not seem to be 
> controversial (yet;) and seem to be useful no matter how the discussion on
> the other series continues.
> 
> ref_transaction_create as well as ref_transaction_delete are just special cases
> of ref_transaction_update, so let's reduce some redundant code. While this doesn't
> change code in pathes, which are supposed to be run, we do have slight changes 
> in error messages starting with "BUG: ". So in the best case, the user will never
> see these messages at all.

Users should *never* see error messages starting with "BUG: ". These are basically what the Git project uses instead of assert(). As long as we Git developers would understand a bug report submitted by a user who sees such an error message, their text can be changed without worries.

Both patches are
Reviewed-by: Michael Haggerty <mhagger@alum.mit.edu>
And I love that you are proceeding in smaller pieces.
Michael
-- 
Michael Haggerty
mhagger@alum.mit.edu
Previous: Junio C Hamano
Message 14 of 14 in “Breaking the ref-transactions-reflog series in smaller parts”
  1. 0/2 Breaking the ref-transactions-reflog series in smaller partsStefan Beller, Nov 19, 2014
  2. 1/2 refs.c: make ref_transaction_create a wrapper for ref_transaction_updateStefan Beller, Nov 19, 2014
  3. Jonathan NiederNov 20, 2014
  4. Stefan BellerNov 20, 2014
  5. Jonathan NiederNov 20, 2014
  6. Jeff KingNov 20, 2014
  7. 1/2 refs.c: make ref_transaction_create a wrapper for ref_transaction_updateStefan Beller, Nov 20, 2014
  8. Jonathan NiederNov 20, 2014
  9. Jeff KingNov 20, 2014
  10. 2/2 refs.c: make ref_transaction_delete a wrapper for ref_transaction_updateStefan Beller, Nov 19, 2014
  11. Jonathan NiederNov 20, 2014
  12. 2/2 refs.c: make ref_transaction_delete a wrapper for ref_transaction_updateStefan Beller, Nov 20, 2014
  13. Junio C HamanoNov 20, 2014
  14. Michael HaggertyNov 20, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.