git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] refs.c: make ref_transaction_create a wrapper for ref_transaction_update

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Nov 20, 2014, 01:10 UTC
Message-ID
<20141120011038.GB6527@google.com>
In-Reply-To
<1416433224-29763-2-git-send-email-sbeller@google.com>
Stefan Beller wrote:
Show 12 quoted lines
> From: Ronnie Sahlberg <sahlberg@google.com>
>
> The ref_transaction_update function can already be used to create refs by
> passing null_sha1 as the old_sha1 parameter. Simplify by replacing
> transaction_create with a thin wrapper.
>
> Signed-off-by: Ronnie Sahlberg <sahlberg@google.com>
> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
>  refs.c | 27 ++-------------------------
>  1 file changed, 2 insertions(+), 25 deletions(-)

I feel a bit ashamed to have my sign-off peppering all these patches that I didn't have anything to do with except preparing to send them to the list once or twice. I'd be happier if my sign-off weren't there.

Except for that,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Previous: Stefan BellerNext: Stefan Beller
Message 3 of 14 in “Breaking the ref-transactions-reflog series in smaller parts”
  1. 0/2 Breaking the ref-transactions-reflog series in smaller partsStefan Beller, Nov 19, 2014
  2. 1/2 refs.c: make ref_transaction_create a wrapper for ref_transaction_updateStefan Beller, Nov 19, 2014
  3. Jonathan NiederNov 20, 2014
  4. Stefan BellerNov 20, 2014
  5. Jonathan NiederNov 20, 2014
  6. Jeff KingNov 20, 2014
  7. 1/2 refs.c: make ref_transaction_create a wrapper for ref_transaction_updateStefan Beller, Nov 20, 2014
  8. Jonathan NiederNov 20, 2014
  9. Jeff KingNov 20, 2014
  10. 2/2 refs.c: make ref_transaction_delete a wrapper for ref_transaction_updateStefan Beller, Nov 19, 2014
  11. Jonathan NiederNov 20, 2014
  12. 2/2 refs.c: make ref_transaction_delete a wrapper for ref_transaction_updateStefan Beller, Nov 20, 2014
  13. Junio C HamanoNov 20, 2014
  14. Michael HaggertyNov 20, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.